Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: navigate to SendTransfer from navbar #2801

Merged
merged 8 commits into from
Sep 6, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Sep 6, 2020

Summary

  • Make activeWallet from URL param optional in SendTransfer.
  • Create new route under profile/:profileId/send-transfer
  • Navigate from Navbar send button to SendTransfer form
  • Sender & Network fields UX tweaks

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Sep 6, 2020
@faustbrian
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #2801 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2801     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       316    +292     
  Lines            142      3979   +3837     
  Branches          18       715    +697     
=============================================
+ Hits             142      3979   +3837     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 336 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bb200...ad4ef24. Read the comment docs.

@faustbrian faustbrian merged commit 1952b04 into 3.0-react Sep 6, 2020
@ghost ghost deleted the feat/navbar-send-transfer branch September 6, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants