Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: update vote bar with votes, unvotes and total #2812

Closed
wants to merge 9 commits into from
Closed

refactor: update vote bar with votes, unvotes and total #2812

wants to merge 9 commits into from

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Sep 8, 2020 •
edited
Loading

Summary

Task: https://app.clickup.com/t/24ynjg

Screenshot from 2020-09-08 14-51-31

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Sep 8, 2020
@brenopolanski brenopolanski marked this pull request as draft September 8, 2020 17:54
boldninja and others added 3 commits September 8, 2020 19:55
@boldninja
chore: optimize 3 SVG(s)
e6af599 
Optimized SVG(s):
- src/app/assets/svg/unvote.svg
- src/app/assets/svg/vote-unvote.svg
- src/app/assets/svg/vote.svg
@brenopolanski
test: fix tests
5321c37
@boldninja
chore: optimize 1 SVG(s)
09c2ae4 
Optimized SVG(s):
- src/app/assets/svg/unvote.svg
@brenopolanski brenopolanski marked this pull request as ready for review September 8, 2020 18:27
@codecov
Copy link

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #2812 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2812     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       319    +295     
  Lines            142      4031   +3889     
  Branches          18       726    +708     
=============================================
+ Hits             142      4031   +3889
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 338 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5099d...d2df8b7. Read the comment docs.

@brenopolanski
Copy link
Contributor Author

Closed PR in favor of #2815

@brenopolanski brenopolanski deleted the refactor/vote-bar branch September 9, 2020 17:44
@ghost ghost mentioned this pull request Sep 13, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brenopolanski @boldninja