Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: icons in news components #2837

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix: icons in news components #2837

merged 1 commit into from
Sep 17, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 17, 2020

Summary

Changes dummy data so the icons in the News components show up again thus fixing the failing e2e test.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2837 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2837     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       325    +301     
  Lines            142      4376   +4234     
  Branches          18       803    +785     
=============================================
+ Hits             142      4376   +4234     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 344 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd85b5...62eb8e7. Read the comment docs.

@faustbrian faustbrian merged commit 9f5336f into 3.0-react Sep 17, 2020
@ghost ghost deleted the fix/news-icons branch September 17, 2020 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants