Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add second signature detail #2871

Merged
merged 8 commits into from
Sep 28, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Sep 25, 2020

Summary

Task: https://app.clickup.com/t/28z4e7

Screenshot from 2020-09-24 22-58-10

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Sep 25, 2020
@brenopolanski brenopolanski marked this pull request as draft September 25, 2020 01:20
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #2871 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2871     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       328    +304     
  Lines            142      4627   +4485     
  Branches          18       850    +832     
=============================================
+ Hits             142      4627   +4485     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 347 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3c943...f59ea7c. Read the comment docs.

@brenopolanski brenopolanski marked this pull request as ready for review September 25, 2020 01:43
@faustbrian faustbrian merged commit 669e443 into 3.0-react Sep 28, 2020
@ghost ghost deleted the feat/2nd-signature-transaction-modal branch September 28, 2020 04:06
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants