Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement Notifications #2873

Merged
merged 112 commits into from
Oct 12, 2020
Merged

feat: implement Notifications #2873

merged 112 commits into from
Oct 12, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Sep 25, 2020 •
edited
Loading

Summary

  • Integrate sdk notifications
  • Implement mark-as-read functionality
  • Show unread notifications sign in menu icon (red dot).
  • Integrate transactions in second section of notifications dropdown (lazy fetch)
  • Add load more functionality in transactions list
  • Handle transaction item click. Open transaction detail modal
  • Add unit test coverage
  • Add e2e tests
  • UI fixes
  • Trigger tx notifications (notification hook & job)
  • Add tests for notifications sync job

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m
chore: add ArkLogo svg
d39de77
@goga-m
refactor: adjust notification models to match sdk
342cbdd
@goga-m
refactor: pass profile instance from NavigationBar
309302a
@goga-m
feat: add utility to map sdk notification action to Action type
1303f23
@goga-m
feat: add NotificationItem component
2509b9b
@goga-m
refactor: adjust tests
d89bb4a
@goga-m
chore: update story data
a048931
@goga-m
Merge branch '3.0-react' into feat/notifications
26667ad
@goga-m
refactor: split sub components in files
90c8179
@goga-m
refactor: remove plugins props dependency, pull from sdk
e19d28e
@goga-m
refactor: use hook to map and translate actions names
1a90f4c
@goga-m
refactor: add notifications wrapper styles
64807ab
@goga-m
chore(deps): add react-visibility-sensor package
8276ef9
@goga-m
feat: emit visibility status on NotificationItem
f6e3ee7
@goga-m
feat: mark as read when visible
9071fc4
@goga-m
feat: show unread notifications sign in navbar notifications icon
a429943
@goga-m
feat: add dummy notification fixtures
16958f0
@goga-m
Merge branch '3.0-react' into feat/notifications
4257b08
@goga-m
chore: remove default plugins mock data from Notifications defaults
5af1f8f
@goga-m
chore: adjust uread dot UI
934cc9e
@goga-m
feat: integrate profile transaction in notifications list
2961ced
@goga-m
feat: add sticky-top-top notification titles while scrolling
70a8f08
@goga-m
refactor: add i18n for all notification texts
0098048
@goga-m
chore: whitespace no wrap on TransactionRowAmount label
a9e59e1
@goga-m
refactor: optional title in Transactions listing
b000c95
@goga-m
chore: modify action props per notification item and transaction item
26fe657
@goga-m
feat: use Transactions with pager and open transaction details in
d58df64 
modal
@goga-m
Merge branch '3.0-react' into feat/notifications
fd414ab
@goga-m
refactor: move NotificationsDropdown to file
55faaff
@goga-m
test: add tests for NotificationItem
66f850b
@faustbrian
Copy link
Contributor

@goga-m conflicts and failing tests

@faustbrian faustbrian merged commit 4563b02 into develop Oct 12, 2020
@ghost ghost deleted the feat/notifications branch October 12, 2020 09:15
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Oct 12, 2020
@ghost ghost mentioned this pull request Oct 18, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian left review comments

@samharperpittam samharperpittam samharperpittam approved these changes

Assignees
No one assigned
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@goga-m @faustbrian @samharperpittam @boldninja @clucasalcantara @luciorubeens