Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjustments and fixes in transfer details #2886

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 28, 2020

Summary

Adjustments and fixes in TransferDetail modal.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2886 into develop will increase coverage by 41.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop     #2886       +/-   ##
=============================================
+ Coverage    58.92%   100.00%   +41.07%     
=============================================
  Files          373       342       -31     
  Lines         9325      4778     -4547     
  Branches      1934       871     -1063     
=============================================
- Hits          5495      4778      -717     
+ Misses        3603         0     -3603     
+ Partials       227         0      -227     
Flag Coverage Δ
#unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/App.tsx 100.00% <ø> (ø)
src/renderer/services/synchronizer/wallets.js
.../TransactionForm/TransactionFormMultiSignature.vue
src/renderer/services/feed.js
...c/renderer/components/Modal/ModalExportWallets.vue
src/renderer/components/Profile/ProfileAvatar.vue
src/renderer/mixins/electron.js
...rc/renderer/components/ProgressBar/ProgressBar.vue
src/renderer/models/market.js
src/renderer/services/plugin-manager.js
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddc65f...58bfec1. Read the comment docs.

@faustbrian faustbrian merged commit 6a644f1 into develop Sep 29, 2020
@ghost ghost deleted the refactor/transfer-details branch September 29, 2020 03:11
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants