Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjustments and fixes in TransactionSuccessful component #2889

Merged
merged 4 commits into from
Sep 29, 2020
Merged

refactor: adjustments and fixes in TransactionSuccessful component #2889

merged 4 commits into from
Sep 29, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 29, 2020 •
edited
Loading

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Sep 29, 2020
@dated dated changed the title refactor: adjustments and fixes in TranasctionSuccessful component refactor: adjustments and fixes in TransactionSuccessful component Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #2889 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2889   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          343       343           
  Lines         4773      4774    +1     
  Branches       872       873    +1     
=========================================
+ Hits          4773      4774    +1
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ransactionExplorerLink/TransactionExplorerLink.tsx 100.00% <100.00%> (ø)
...ts/TransactionSuccessful/TransactionSuccessful.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12be916...e2de3e0. Read the comment docs.

@dated dated marked this pull request as ready for review September 29, 2020 11:09
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 29, 2020
@faustbrian faustbrian merged commit 4ba2bd8 into develop Sep 29, 2020
@ghost ghost deleted the refactor/success branch September 29, 2020 14:19
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 29, 2020
@ghost ghost mentioned this pull request Oct 4, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dated @faustbrian