Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: adjustments to delegate registration form #2905

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 1, 2020

Summary

https://app.clickup.com/t/8pqww6

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner October 1, 2020 05:56
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 1, 2020
@ArkEcosystem ArkEcosystem deleted a comment from faustbrian Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2905 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          347       349    +2     
  Lines         4889      4889           
  Branches       901       901           
=========================================
  Hits          4889      4889           
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nsaction/components/MultiSignatureDetail/Step1.tsx 100.00% <ø> (ø)
...components/TransactionDetail/TransactionDetail.tsx 100.00% <ø> (ø)
...ts/TransactionSuccessful/TransactionSuccessful.tsx 100.00% <ø> (ø)
...transaction/pages/SendEntityRegistration/Step3.tsx 100.00% <ø> (ø)
src/domains/transaction/pages/SendIpfs/Step2.tsx 100.00% <ø> (ø)
src/domains/transaction/pages/SendIpfs/Step4.tsx 100.00% <ø> (ø)
...c/domains/transaction/pages/SendTransfer/Step4.tsx 100.00% <ø> (ø)
src/domains/transaction/pages/SendVote/Step1.tsx 100.00% <ø> (ø)
src/domains/transaction/pages/SendVote/Step2.tsx 100.00% <ø> (ø)
src/domains/transaction/pages/SendVote/Step4.tsx 100.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207fd8e...2e38a87. Read the comment docs.

@faustbrian faustbrian merged commit a611f67 into develop Oct 1, 2020
@ghost ghost deleted the refactor/delregis-CU-8pqww6 branch October 1, 2020 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants