Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: improve amount and send max in send transfer #2910

Merged
merged 4 commits into from
Oct 3, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Use the maximum amount available based on the sender wallet balance and selected fee.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #2910 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2910   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          349       349           
  Lines         4893      4905   +12     
  Branches       903       904    +1     
=========================================
+ Hits          4893      4905   +12     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ansaction/components/AddRecipient/AddRecipient.tsx 100.00% <100.00%> (ø)
...ns/transaction/pages/SendTransfer/SendTransfer.tsx 100.00% <100.00%> (ø)
...c/domains/transaction/pages/SendTransfer/Step1.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8eeda6...fe557b5. Read the comment docs.

@faustbrian faustbrian merged commit 472971e into develop Oct 3, 2020
@ghost ghost deleted the fix/send-transfer branch October 3, 2020 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants