Stop Import/Create account if no network #341
Conversation
|
well the thing it SHOULD be possible to create/import account while offline. That is because this function fails https://github.com/alexbarnsley/ark-desktop/blob/c46e25d162f5e2cc1dd37bd3084a4c1d286b4524/client/app/src/accounts/account.service.js#L158 if not connected. Maybe add a fail function where the account is still created/imported or here fails gradefully (ie |
|
Sounds good to me @fix, I'll make the amends :) |
|
@fix I've made a change so now it adds an "empty" account if the getFromPeer request fails. Please could you give it another test, thanks! Edit: I've also removed the original code from this PR |
|
Nice! 👍🏻 +5 |
* fix: add check for sending enabled on wallet * test: fix failing tests with missing mixin * fix: disable vote button if send disabled
This fixes an issue with not being connected to a network, when importing or creating an account it just does nothing with no feedback at all. I've implemented a toast notification when clicking "Import Account" or "Create Account" - see below. Feel free to test the before and after of not being connected to a network to see the issue I'm referring to.