This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Exit ledger-worker process on quit signal #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spresnal
approved these changes
Oct 21, 2017
|
sounds good! 👍🏻 +5 |
Closed
alexbarnsley
pushed a commit
that referenced
this pull request
Dec 3, 2018
* feat: add a new property to networks: `subunit` * feat: allow formatting currencies by the subunit (arktoshi) instead of unit (ARK) * feat: adapt the `InputCurrency` component to include it on the transfer modal * feat: implement `currency_unitToSub` * feat: admit using "," as decimal separator on `InputCurrency` * refactor: currency mixin * test: check that now numbers on the `InputCurrency` could use "," as decimal separator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported on reddit saying that instances of Ark were still running after the client was closed. I found that the ledger-worker was not being closed when ArkClient was closed, so ledger-worker.js and main.js were still running.
I fixed it by calling process.exit() in ledger-worker when it receives a quit message. All parts of the client now exit completely when the window is closed.