refactor: wallet import options depending on the network

[w3ea]

Summary

https://app.clickup.com/t/jzbxze

Checklist

• My changes look good in both light AND dark mode
• The change is not hardcoded to a single network, but has multi-asset in mind
• I checked my changes for obvious issues, debug statements and commented code
• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[faustbrian]

This should also respect the default flag to pre-select an option.

[w3ea]

This should also respect the default flag to pre-select an option.

i know about that
https://github.com/ArkEcosystem/platform-sdk/blob/master/packages/platform-sdk-ark/src/networks/shared.ts#L25-L38
but before implement it i have some questions, and i'll ask them in Slack

[faustbrian]

ArkEcosystemArchive/platform-sdk@1dee2a9
ArkEcosystemArchive/platform-sdk@3533031
ArkEcosystemArchive/platform-sdk@3e75a26

• In 8.5.0 there is a breaking change to split up the mnemonic methods instead of relying on a parameter and if branches.
• In 8.6.0 and 8.7.0 there are breaking changes to merge the non-encryption and encryption methods in the wallet factory.

[faustbrian]

@w3ea what's the status on this?

[w3ea]

@faustbrian working on fixing test
but about psdk 8.6.0 and 8.7.0, you fixed it, right?
i can't see any fromMnemonicWithEncryption method

[faustbrian]

As I stated in the comment before: In 8.6.0 and 8.7.0 there are breaking changes to merge the non-encryption and encryption methods in the wallet factory, thus fromMnemonicWithEncryption no longer exists but is now handled by passing in a password property to fromMnemonic in addition to the usual.

[faustbrian]

@w3ea what's the status on this?

[w3ea]

@w3ea what's the status on this?

@faustbrian it had completed, but after recently merge it shows some test errors, i should check theme

[faustbrian]

Missing coverage

[w3ea]

@faustbrian I also wanted to ask about this
we're using ark in the test and as you know we have limit import options from psdk,
https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/domains/wallet/pages/ImportWallet/ImportWallet.test.tsx#L304-L307
i'm not sure how to mock other coin like btc to coverage all other import options
https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/domains/wallet/pages/ImportWallet/Step2.tsx#L134-L178

[faustbrian]

For methods that we don't yet actually support you can skip the tests and/or ignore the coverage.