-
Notifications
You must be signed in to change notification settings - Fork 193
Resolve contacts in send form & optimizations #524
Conversation
9388084
to
11bf172
Compare
dae97b4
to
2f434c6
Compare
@j-a-m-l fixed conflicts ;) |
I changed this a little. I now like it much more than what I did before, see screenshots here: |
2fef211
to
1d41f48
Compare
Now it works slightly different, please, @Nasicus take a look. Probably your way is better. |
1d41f48
to
f374529
Compare
The final gif of how it looks and works: |
- find account labels on type - add icons for contacts & wallets - always order by contacts, accounts, alphabetical - resolve contacts on field blur if the match an existing account or contact exactly - show account type info on validation page (contact / account) - don't allow to send form when address is empty
f374529
to
55222b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how it's working now, but I'd change the account icons to be the same that are being used in the sidebar (client/app/src/components/account/templates/main-sidenav.html
).
Problem is that they look almost the same as contacts. |
There are 4 types:
I think that it's useful knowing which accounts haven't been used yet. One way to differentiate them could be using different colours. |
Damn it you're right - totally forgot about these. However I don't think it would be good to use all these different icons in the search box, because the aim of the current two icons is to clearly distinguish between contacts and accounts / wallets. What is your current proposed solution? I must send I don't know what'd be best... |
I understand you point, but I think that it's better to maintain the familiar icons instead of using a new one. |
At @j-a-m-l what do you say now: I also added a tooltip if you hover over the icon in the dropdown (of course the tooltip is also shown once you select an account/contact): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that setting the icon in myAccounts
is enough (as long as the accounts don't change).
Good work! |
* fix: reload session after reset on app launch * refactor: set i18n locale on session change * fix: reload profile when leaving new profile page
This does the following:
Invalid Address
error is not shown if you're typing the name of a contact.Fixes: #520