This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
(ignore the branch name - i'm considering this a feature instead of a fix)
The app now has a hardcoded 45 minute value for how long it takes for transactions to expire. This is set in core, and there's no endpoint that provides this value. I thought about adding a network modal field, but I didn't want it to confuse users when adding custom networks. It can be added in the future if it causes issues.
To sum up, an unconfirmed transaction is stored in the local database. This remains until the transaction is processed and received, or the 45 minute period ends. At this point it is removed from the local database. If a wallet is in view with a transaction that expires, it will get a
strikethroughand remain the unconfirmed grey.Resolves #644
Types of changes
Checklist