Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add i18n to eslint ignore #699

Merged
merged 5 commits into from
Dec 10, 2018
Merged

fix: add i18n to eslint ignore #699

merged 5 commits into from
Dec 10, 2018

Conversation

dated
Copy link
Contributor

@dated dated commented Dec 10, 2018

Proposed changes

The <i18n> does not work when written in PascalCase (<I18n>) as required by the current lint rules. This PR adds the i18n tag to the eslint ignore rules.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Copy link
Contributor

@luciorubeens luciorubeens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dated Need to match the latest changes, check WalletDetails.

@luciorubeens luciorubeens merged commit b50f20b into ArkEcosystem:develop Dec 10, 2018
@luciorubeens
Copy link
Contributor

👍🏻

@dated dated deleted the i18n-eslint branch December 10, 2018 16:19
zillionn pushed a commit to zillionn/desktop-wallet that referenced this pull request Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants