Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network modal button disabling #885

Merged
merged 2 commits into from Dec 30, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 29, 2018

Proposed changes

The remove button should be available even if a field is invalid, since you want to remove it anyway. The save button had an issue as a name was seen as "duplicate" in the form as there was an existing network with that name when you tried to edit it. This PR adds an extra check to ensure that the same name is allowed if we're currently editing that network.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
fix: enable removing network even if a field is invalid, and fix issu…
…e where saving did not work as name was regarded as duplicate

@faustbrian faustbrian merged commit 58de699 into develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/network-modal-validation branch Dec 30, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.