This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: network modal button disabling #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e where saving did not work as name was regarded as duplicate
faustbrian
approved these changes
Dec 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
removebutton should be available even if a field is invalid, since you want to remove it anyway. Thesavebutton had an issue as a name was seen as "duplicate" in the form as there was an existing network with that name when you tried to edit it. This PR adds an extra check to ensure that the same name is allowed if we're currently editing that network.Types of changes
Checklist