Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delegate wallet info boxes #719

Merged
merged 75 commits into from
May 27, 2021

Conversation

Highjhacker
Copy link
Contributor

@Highjhacker Highjhacker commented May 17, 2021

Summary

https://app.clickup.com/t/jd8b29

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@Highjhacker
Copy link
Contributor Author

Mostly good for now, have some padding issues where there's too much padding between elements, but feel like it would be more suited for a separate PR since it doesn't touch directly the components I'm working on here, will still have another sanity check after lunch break.

@Highjhacker Highjhacker marked this pull request as ready for review May 18, 2021 12:34
@samharperpittam
Copy link

samharperpittam commented May 18, 2021

@Highjhacker

Can you please confirm if you in your local env that standby and resigned delegates all have green tick and incorrect "status"? (standby showing as active)

image

image

It could be an issue with my local env but i'm not sure what it could be.

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'See All' links for Forged Blocks and Votes should be right aligned.

Design
image

Implementation
image

(Also the title text looks a different colour, should be using secondary-500, currently using secondary 700)

@Highjhacker
Copy link
Contributor Author

@samharperpittam No you are right, just double checked in designs, missed it

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Forged Blocks and Votes title should also be right aligned so 'Votes' is aligned with the QR code scan button

Design
image

Implementation
image

@samharperpittam samharperpittam marked this pull request as draft May 18, 2021 15:22
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an address has been resigned, the following needs changing

  • The status icons should be grey (1)
  • The #0 Rank needs to be hidden (2)
  • The 'Productivity' stat needs to be hidden (3)
  • The total forged value changes to secondary-500

Design
image

Implementation
image

@Highjhacker
Copy link
Contributor Author

Most of your requested changes are now made @samharperpittam but gonna have a look at the whole layout of it, it really can get funky right now with all the tiny possible changes, so need something that handle that better, I'll tag you again once it's good :lala:

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 768 & 640 - Bottom padding not aligned to 'See All' correctly.

image

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Standby (dark mode). 'Standby' text should be dark:text-theme-secondary-700
    image

Design
image

Also there's no need to have a space between # and the number.

# 52 becomes #52

Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Resigned (dark mode). 'Total Forged' value should be dark:text-theme-secondary-700

image

Design
image

@ItsANameToo ItsANameToo marked this pull request as ready for review May 27, 2021 14:23
@ItsANameToo ItsANameToo merged commit 9acbaf3 into deps-and-padding May 27, 2021
@ItsANameToo ItsANameToo deleted the refactor/delegate-wallet-info-boxes branch May 27, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants