Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Inter as font #783

Merged
merged 6 commits into from Jan 13, 2020
Merged

feat: use Inter as font #783

merged 6 commits into from Jan 13, 2020

Conversation

@ItsANameToo
Copy link
Member

ItsANameToo commented Nov 29, 2019

Replaces Proxima Nova with Inter

  • figure out why base size is stuck on 16px even though it's defined as 15px
@ItsANameToo ItsANameToo marked this pull request as ready for review Nov 29, 2019
@ItsANameToo ItsANameToo requested a review from faustbrian as a code owner Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #783 into develop will decrease coverage by 2.43%.
The diff coverage is 19.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #783      +/-   ##
===========================================
- Coverage    43.98%   41.55%   -2.44%     
===========================================
  Files          143      159      +16     
  Lines         2687     2965     +278     
  Branches       372      401      +29     
===========================================
+ Hits          1182     1232      +50     
- Misses        1505     1733     +228
Flag Coverage Δ
#unittests 41.55% <19.28%> (-2.44%) ⬇️
Impacted Files Coverage Δ
src/components/tables/mobile/Businesses.vue 0% <ø> (ø) ⬆️
src/components/transaction/Details.vue 41.07% <ø> (ø) ⬆️
src/pages/Transaction.vue 0% <ø> (ø) ⬆️
src/pages/Businesses.vue 0% <ø> (ø) ⬆️
src/locales/en-GB.ts 100% <ø> (ø) ⬆️
src/components/tables/mobile/Bridgechains.vue 0% <ø> (ø) ⬆️
src/components/header/menu/Mobile.vue 100% <ø> (ø) ⬆️
src/components/wallet/Details.vue 0% <ø> (ø) ⬆️
src/components/links/LinkWallet.vue 82% <ø> (ø) ⬆️
src/components/Modal.vue 100% <ø> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da90bb...20b3281. Read the comment docs.

@ItsANameToo

This comment has been minimized.

Copy link
Member Author

ItsANameToo commented Nov 29, 2019

back to wip; need to check the influence of text-base on the overall sizes in the explorer 🤔

@ItsANameToo ItsANameToo changed the title feat: use Inter as font [WIP] feat: use Inter as font Nov 29, 2019
@ItsANameToo ItsANameToo changed the title [WIP] feat: use Inter as font feat: use Inter as font Nov 29, 2019
@ItsANameToo ItsANameToo merged commit 9de1d77 into develop Jan 13, 2020
12 of 14 checks passed
12 of 14 checks passed
e2e (12.x)
Details
e2e (12.x)
Details
unit (12.x)
Details
unit (12.x)
Details
build-devnet (12.x)
Details
build-devnet (12.x)
Details
build-mainnet (12.x)
Details
build-mainnet (12.x)
Details
build-testnet (12.x)
Details
build-testnet (12.x)
Details
codecov/patch 19.28% of diff hit (target 43.98%)
Details
codecov/project 41.55% (-2.44%) compared to 1da90bb
Details
codeclimate All good!
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the feat/font branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.