fix: remove id on all svg icons #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
samharperpittam
as code owners
Optimized SVG(s): - public/images/search/empty-dark.svg - public/images/search/empty.svg - resources/icons/arrow-down.svg - resources/icons/arrow-up.svg - resources/icons/block-id.svg - resources/icons/confirmations.svg - resources/icons/delegate-name.svg - resources/icons/delegate.svg - resources/icons/exchange.svg - resources/icons/height.svg - resources/icons/monitor.svg - resources/icons/nonce.svg - resources/icons/price.svg - resources/icons/qr-code.svg - resources/icons/rank.svg - resources/icons/reward.svg - resources/icons/smartbridge.svg - resources/icons/supply.svg - resources/icons/transaction.svg - resources/icons/transactions.svg - resources/icons/verified.svg - resources/images/search/empty-dark.svg - resources/images/search/empty.svg
9 tasks
6 tasks
ItsANameToo
approved these changes
Sep 28, 2021
|
This in itself doesn't resolve all the issues, so keeping the clickup card open for now |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/1jktfgf
Removes the id from SVG icons to prevent issue described on the ticket
Checklist