fix: remove svgs ids #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
force-pushed
the
fix/remove-svg-ids
branch
from
968712e
to
fd8adbd
Compare
Optimized SVG(s): - resources/assets/icons/arrow-rotate-left.svg - resources/assets/icons/bookmark.svg - resources/assets/icons/brands/abra.svg - resources/assets/icons/brands/android.svg - resources/assets/icons/brands/ark_black.svg - resources/assets/icons/brands/atomic.svg - resources/assets/icons/brands/blog.svg - resources/assets/icons/brands/coingecko.svg - resources/assets/icons/brands/crypto_com.svg - resources/assets/icons/brands/deployer.svg - resources/assets/icons/brands/exodus.svg - resources/assets/icons/brands/facebook.svg - resources/assets/icons/brands/github.svg - resources/assets/icons/brands/gitlab.svg - resources/assets/icons/brands/ios.svg - resources/assets/icons/brands/linkedin.svg - resources/assets/icons/brands/linux.svg - resources/assets/icons/brands/macos.svg - resources/assets/icons/brands/marketsquare.svg - resources/assets/icons/brands/medium.svg - resources/assets/icons/brands/nodem.svg - resources/assets/icons/brands/npm.svg - resources/assets/icons/brands/outline/amazon.svg - resources/assets/icons/brands/outline/appstore.svg - resources/assets/icons/brands/outline/bitbucket.svg - resources/assets/icons/brands/outline/discord.svg - resources/assets/icons/brands/outline/facebook.svg - resources/assets/icons/brands/outline/github.svg - resources/assets/icons/brands/outline/gitlab.svg
Optimized SVG(s): - resources/assets/icons/bookmark.svg - resources/assets/icons/brands/android.svg - resources/assets/icons/brands/ios.svg - resources/assets/icons/brands/nodem.svg
alfonsobries
requested review from
alexbarnsley and
ItsANameToo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces: ArkEcosystemArchive/laravel-ui#664
Related: ArkEcosystem/explorer#941
Ticket: https://app.clickup.com/t/1jktfgf
id="[^"]*"and made a manual scroll through all the changes to spot unexpected stuff. (feel confident with the change)http://laravel-foundation.test/icons.html(or your own local server)Checklist
icons.htmlfile and checked if my newly added icon is shown correctly (if necessary)