Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.

fix: return types and laravel helper function #28

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

repat
Copy link
Contributor

@repat repat commented Sep 18, 2020

Summary

  • Changed array_only to Arr::only, since the helper package is not necessarily installed
  • Fixed return types
  • Updated link to documentation

Why are these changes necessary?

I couldn't use the package, the return types are part of PHP and therefore a hard error and not possible try/catch.

How were these changes implemented?

See changed files, it's not much :)

Checklist

  • Documentation (if necessary)
  • Tests (if necessary) -> there are no tests?
  • Ready to be merged
➜ ./vendor/bin/phpunit
PHPUnit 9.3.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.10
Configuration: /.../laravel-1/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

No tests executed!

@ghost
Copy link

ghost commented Sep 18, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #28   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity       16      16           
========================================
  Files             4       4           
  Lines            52      52           
========================================
  Misses           52      52           
Impacted Files Coverage Δ Complexity Δ
src/ArkFactory.php 0.00% <0.00%> (ø) 5.00 <1.00> (ø)
src/ArkManager.php 0.00% <0.00%> (ø) 4.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df9f27...c412f93. Read the comment docs.

@faustbrian faustbrian changed the title Fix return types, Update Documentation link, Fix laravel helper function fix: return types and laravel helper function Sep 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 18, 2020
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 18, 2020
@faustbrian faustbrian merged commit 1f1f642 into ArkEcosystemArchive:master Sep 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants