refactor: use the activeDelegates number provided by the network #336
Conversation
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
ghost
added
the
Status: Needs Changes
|
Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
|
Thanks @luciorubeens. Anything else? |
ghost
added
the
Status: Member Approved
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
luciorubeens
added
the
Bounty: Tier 3
|
The ci/circleci: test-node-9 job is failing as of 721eff5702546f78ef44c72bb94e1ea03a881670. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
The ci/circleci: test-node-9 job is failing as of 238fae76b99023a4deb1b7190fbf999bc1692d63. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
luciorubeens
changed the title
|
Your pull request has been merged and marked as tier 3. It will earn you $25 USD. |
ghost
mentioned this pull request
* refactor: 51 delegate limit to activeDelegates limit * changes * fix: update `activeDelegates` on node configuration response * test: fix type * test: fix trailing whitespace
* refactor: qr-code regex (#298) * feat: add top wallets list (#312) * fix: show keyboard on ios (#297) * refactor: use the activeDelegates number provided by the network (#336) * refactor: 51 delegate limit to activeDelegates limit * changes * fix: update `activeDelegates` on node configuration response * test: fix type * test: fix trailing whitespace * fix: update the wallet in the correct profile (#339) * chore: fix some punctuation mistakes (#340) * chore: bump to 1.4.3 (#342) * chore: use organization-wide GitHub Configuration (#343) * chore: update ark-ts to change the peer config endpoint (#344) * refactor: display the remote error message when it exists * chore: bump to 1.4.4 * perf: clear intervals when navigating to another page * fix: get fees for 7 days instead of 30 * fix: avoid bignumber error when typing decimals * fix: display zero balance in the wallets list * fix: continue updating current wallet when navigating to others pages * fix: do not hang the app while finding a good peer * refactor: migrate to v2 api (#350) * refactor: migrate to v2 api * fix: fetch and post transactions * feat: handle enter key when manually importing wallet (#354) * refactor: use activeDelegates provided by network (#355) * refactor: use activeDelegates provided by network * fix: use StoredNetwork instead of Network * fix: handle transaction amount as a string (#356) * fix: handle transaction amount as a string * fix: handle NaN on equivalent amount in fiat * fix: change the send amount only on blur * fix: lint * fix: typo preminned to premined (#357) * chore: bump to 1.5.0 (#359)
Proposed changes
We refactor the static 51 limit to an activeDelegates limit, which resolves #335.