Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix typo preminned to premined #357

Merged
merged 2 commits into from
Jul 8, 2019
Merged

fix typo preminned to premined #357

merged 2 commits into from
Jul 8, 2019

Conversation

Mililiter94
Copy link
Contributor

@Mililiter94 Mililiter94 commented Jul 6, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Just a typo fix.

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Jul 6, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Jul 6, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Jul 6, 2019
@luciorubeens luciorubeens added the Bounty: Tier 6 Awarded for typos, text corrections, dependency updates, etc. This is valued at 0 USD. label Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Jul 8, 2019
@luciorubeens luciorubeens merged commit 8a14579 into ArkEcosystem:develop Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

Your pull request has been merged and marked as tier 6. It will earn you $1 USD.

luciorubeens added a commit that referenced this pull request Jul 12, 2019
* refactor: qr-code regex (#298)

* feat: add top wallets list (#312)

* fix: show keyboard on ios (#297)

* refactor: use the activeDelegates number provided by the network (#336)

* refactor: 51 delegate limit  to activeDelegates limit

* changes

* fix: update `activeDelegates` on node configuration response

* test: fix type

* test: fix trailing whitespace

* fix: update the wallet in the correct profile (#339)

* chore: fix some punctuation mistakes (#340)

* chore: bump to 1.4.3 (#342)

* chore: use organization-wide GitHub Configuration (#343)

* chore: update ark-ts to change the peer config endpoint (#344)

* refactor: display the remote error message when it exists

* chore: bump to 1.4.4

* perf: clear intervals when navigating to another page

* fix: get fees for 7 days instead of 30

* fix: avoid bignumber error when typing decimals

* fix: display zero balance in the wallets list

* fix: continue updating current wallet when navigating to others pages

* fix: do not hang the app while finding a good peer

* refactor: migrate to v2 api (#350)

* refactor: migrate to v2 api

* fix: fetch and post transactions

* feat: handle enter key when manually importing wallet (#354)

* refactor: use activeDelegates provided by network (#355)

* refactor: use activeDelegates provided by network

* fix: use StoredNetwork instead of Network

* fix: handle transaction amount as a string (#356)

* fix: handle transaction amount as a string

* fix: handle NaN on equivalent amount in fiat

* fix: change the send amount only on blur

* fix: lint

* fix: typo preminned to premined (#357)

* chore: bump to 1.5.0 (#359)
@boldninja
Copy link
Member

@Mililiter94 Can you provide me with your ARK address for GitHub bounty? You can also contact me on ARK's Slack - https://ark.io/slack (username : Rok [ARK Team]) and direct message me your address there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 6 Awarded for typos, text corrections, dependency updates, etc. This is valued at 0 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants