Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: update the wallet in the correct profile #339

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

luciorubeens
Copy link
Contributor

@luciorubeens luciorubeens commented Jun 3, 2019

Proposed changes

Some async tasks are completed after the user toggles the profile, causing the wallet data to be saved to the wrong profile.

Resolves #337

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jun 3, 2019
@luciorubeens luciorubeens merged commit 50b0481 into develop Jun 5, 2019
@ghost ghost deleted the fix/incorrect-wallets branch June 5, 2019 12:16
luciorubeens added a commit that referenced this pull request Jul 12, 2019
* refactor: qr-code regex (#298)

* feat: add top wallets list (#312)

* fix: show keyboard on ios (#297)

* refactor: use the activeDelegates number provided by the network (#336)

* refactor: 51 delegate limit  to activeDelegates limit

* changes

* fix: update `activeDelegates` on node configuration response

* test: fix type

* test: fix trailing whitespace

* fix: update the wallet in the correct profile (#339)

* chore: fix some punctuation mistakes (#340)

* chore: bump to 1.4.3 (#342)

* chore: use organization-wide GitHub Configuration (#343)

* chore: update ark-ts to change the peer config endpoint (#344)

* refactor: display the remote error message when it exists

* chore: bump to 1.4.4

* perf: clear intervals when navigating to another page

* fix: get fees for 7 days instead of 30

* fix: avoid bignumber error when typing decimals

* fix: display zero balance in the wallets list

* fix: continue updating current wallet when navigating to others pages

* fix: do not hang the app while finding a good peer

* refactor: migrate to v2 api (#350)

* refactor: migrate to v2 api

* fix: fetch and post transactions

* feat: handle enter key when manually importing wallet (#354)

* refactor: use activeDelegates provided by network (#355)

* refactor: use activeDelegates provided by network

* fix: use StoredNetwork instead of Network

* fix: handle transaction amount as a string (#356)

* fix: handle transaction amount as a string

* fix: handle NaN on equivalent amount in fiat

* fix: change the send amount only on blur

* fix: lint

* fix: typo preminned to premined (#357)

* chore: bump to 1.5.0 (#359)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridgechain Wallet in my Ark wallet!
1 participant