Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: add storage service unitary tests #506

Merged
merged 7 commits into from
Mar 4, 2020
Merged

test: add storage service unitary tests #506

merged 7 commits into from
Mar 4, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

It's tests season 🎉 🚀 🥇

We are gradually adding tests to cover our functionalities, in this PR you'll find:

  • Enable code coverage
  • Add storage service unitary tests
  • Disable random run for jasmine to avoid test execution errors

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara added Test: Unit The issue or pull request is related to unit tests for testing individual elements. Environment: Test The issue or pull request affects the test environment. labels Mar 3, 2020
@clucasalcantara clucasalcantara self-assigned this Mar 3, 2020
@ghost ghost added Complexity: Low Less than 64 lines changed. Status: In Progress The issue or pull request is being worked on. labels Mar 3, 2020
@faustbrian faustbrian changed the title test: Add storage service unitary tests test: add storage service unitary tests Mar 3, 2020
@clucasalcantara clucasalcantara marked this pull request as ready for review March 4, 2020 13:28
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Mar 4, 2020
@luciorubeens luciorubeens merged commit 7a79968 into develop Mar 4, 2020
@ghost ghost deleted the test/add-storage-unitary branch March 4, 2020 16:45
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Mar 4, 2020
@ghost ghost mentioned this pull request Mar 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luciorubeens luciorubeens luciorubeens approved these changes

Assignees

@clucasalcantara clucasalcantara

Labels
Complexity: Low Less than 64 lines changed. Environment: Test The issue or pull request affects the test environment. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clucasalcantara @luciorubeens