Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: exclude current wallet when updating label #684

Closed
wants to merge 54 commits into from
Closed

fix: exclude current wallet when updating label #684

wants to merge 54 commits into from

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 24, 2020

Summary

Excludes the given wallet when checking if the label can be updated.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

luciorubeens and others added 30 commits March 30, 2020 09:19
@luciorubeens
chore: merge master into develop (#551)
a498ed6
@luciorubeens
chore: update deps (#552)
37f5c09 
* chore: update @angular/core

* chore: update @angular/core

* chore: update @Ionic packages

* chore: update other deps
@luciorubeens
chore: resolve UIWebView API deprecation (#553)
34d7dc3
@clucasalcantara
fix: capitalize translation items (#554)
7fd86ea
@clucasalcantara @luciorubeens
feat: add neo-api unit tests (#555)
c43ba96 
* test(wip): add basic test structure

* test: add neo api test cases

* test: add test case using get balance with transactions fixtures

* chore: remove single test run flag

* fix: remove duplicate factory

Co-authored-by: Lucio Rubens <4539235+luciorubeens@users.noreply.github.com>
@luciorubeens
feat: add bottom drawer component (#556)
09e3e29 
* feat: add bottom drawer component

* refactor: use bottom drawer in wallet picker

* test: add bottom drawer specs

* fix: remove single test flag

* test: fix input-address
@renovate @renovate-bot
fix(deps): update dependency pino-pretty to v4 (#557)
7099ad3 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@clucasalcantara @luciorubeens
test: add ark api test cases (#560)
a8f78a7 
* test: [wip] add initial structure

* fix: activate network

* test: wip covering public get methods

* fix: should complete

* test: wip - get network fee statistics

* test: wip network fee statistics

* test: wip cover more cases in statistics context

* test: wip add fees test case and fixture

* fix: node/fees request

* test: wip add cached fees case

* test: wip should use cached fees case

* test: wip should fetch and return delegates

* fix: cached fees

* fix: skip delegates

* refactor: fetch fees

* test: wip inscrease ark api coverage

* test: wip: add validateAddress and getDelegateByPk

* test: adjust network version

* ci: fix webdriver version

Co-authored-by: Lucio Rubens <4539235+luciorubeens@users.noreply.github.com>
@renovate @renovate-bot @luciorubeens
chore(deps): update dependency karma to v5 (#559)
453b7e0 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Lúcio Rubens <4539235+luciorubeens@users.noreply.github.com>
@clucasalcantara
feat: add status component (#564)
a11b257 
* feat: add status component

* chore: remove single test run flag

* feat: add warning and error variations, apply svg

* test: update test cases to new component structure

* feat: update component usage

* refactor: apply review suggestions
@kalgoop @luciorubeens
fix: preserve whitespace in passphrase and truncate long profile (#562)
b1dd699 
* Update wallet-backup.html

* Update app.component.spec.ts

* Update app.component.html

* Fix lint errors

* Update app.module.ts

Co-authored-by: Lúcio Rubens <4539235+luciorubeens@users.noreply.github.com>
@renovate @renovate-bot @clucasalcantara
chore(deps): update dependency @types/pino to v6 (#565)
cdd9ad6 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@luciorubeens @clucasalcantara
refactor: improve authorization module (#561)
32cacfa 
* feat: authorization flow

* feat: auth-pin component

* refactor: add lock period

* refactor: add mode state

* refactor: add confirmation mode

* feat: initial touch id impl

* refactor: setup tabs navigation

* refactor: convert seconds to timestamp

* feat: add ngxs storage plugin

* fix: update icons

* refactor: impl auth ctrl on profile signin

* refactor: remove touch-id support for now

* refactor: switch pin component on login page

* refactor: impl auth on settings page

* refactor: impl auth on transaction send page

* refactor: impl auth on delegates page

* refactor: remove old pin-code components

* test: add auth service specs

* test: add auth state specs

* fix: add wallet module

* test: add auth pin specs

* test: add last spec in the auth pin

* test: add auth component specs

* test: init auth controller specs

* test: add register pin specs

* fix: remove single test flag

* fix: remove fingerprint-aio plugin

Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@luciorubeens @clucasalcantara
feat: add wallet identicon component (#566)
7ab42bb 
* feat: add identicon component

* test: add component specs

* test: remove single test flag

Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@clucasalcantara
refactor: redesign intro page (#567)
2fa54bd 
* feat: use new intro module instead of page

* refactor: update intro module state to ngxs new approach

* feat: add intro state to ngxs storage plugin

* refactor: remove unused module

* refactor: wip - intro state token and rehydrate

* feat: redesign intro page

* test: wip add new intro tests

* chore: updates security intro step text

* test: update intro tests

* chore: adjust skip button size

* refactor: remove platform ready, rename style

* refactor: move config to shared folder

* feat: add intro pagination component

* refactor: update intro page component

* refactor: use prop instead state to paginationSize

* chore: rollback step 2 text

* chore: update intro storage key

* refactor: check legacy store and update new intro state

* refactor: remove unnecessary action

* refactor: remove old intro page
@luciorubeens
refactor: initial delegates redesign (#568)
c968222 
* refactor: initial delegates redesign

* feat: add delegate unvote banner component

* feat: add initial delegate search component

* wip

* fix: lazy loading routes

* refactor: add infinite scroll

* test: add delegate list specs

* test: add unvote banner specs

* fix: add forRoot method

* test: add state specs

* fix: lazy loading
@luciorubeens
fix: authorization confirmation and tweaks (#569)
47fca6d 
* chore: move auth files to shared folder

* chore: move shared module to shared folder

* fix: readd vibration when wrong

* fix: wait to dismiss before opening confirmation

* fix: failing test
@luciorubeens
refactor: realign the intro page (#572)
3e48f3e 
* refactor: realign the intro page

* chore: intro -> onboarding

* feat: add custom storage plugin for ngxs

* feat: add onboarding guard

* chore: rename svg files

* fix: auth storage key

* test: fix failing

* chore: remove old images

* test: add async storage plugin specs

* fix: improve onboarding service

* test: add onboard guard
@renovate @renovate-bot @clucasalcantara
chore(deps): update dependency ts-node to ~8.9.0 (#571)
06e1971 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@kalgoop @clucasalcantara
feat: allow removal of wallet label (#573)
d788406 
* Update set-label.html

* Update set-label.ts

* Update user-data.ts

Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@clucasalcantara
refactor: empty wallets list redesign (#574)
efda00d
@luciorubeens
refactor: initial transactions module (#575)
ed36edc 
* feat: initial transaction vote component

* refactor: implement transaction-vote on delegates page

* refactor: add transaction form state

* refactor: bignumber usage

* refactor: transaction detail component

* test: add transaction-detail specs

* test: add transaction vote specs

* test: add transaction state specs

* test: add transaction vote ctrl specs
@clucasalcantara
refactor: initial network list redesign (#576)
0becca7
@luciorubeens
refactor: add market module (#578)
106a10e
@luciorubeens
chore: update deps (#585)
698920b 
* chore: update internal packages

* chore: update @angular/cli deps

* chore: update @angular/core deps

* chore: minor updates

* chore: update other deps

* fix: failing
@clucasalcantara
refactor: settings redesign (#580)
549c0ae
@clucasalcantara
feat: add custom font family (#586)
0dd20fe
@renovate
chore(deps): update dependency eslint to v7 (#592)
d4c84e9
@renovate @renovate-bot
fix(deps): update dependency @arkecosystem/platform-sdk to ^0.7.0 (#596)
ba6f4c0 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@renovate @renovate-bot @faustbrian
fix(deps): update dependency @arkecosystem/platform-sdk-markets to ^0…
7c05ce3 
….7.0 (#597)

* fix(deps): update dependency @arkecosystem/platform-sdk-markets to ^0.7.0

* fix: use new exports

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Brian Faust <hello@basecode.sh>
clucasalcantara and others added 21 commits May 15, 2020 07:18
@clucasalcantara
refactor: wallets list redesign (#593)
0f2669a
@clucasalcantara
feat: redesign wallet passphrase list (#605)
00e7703
@renovate @renovate-bot @clucasalcantara
fix(deps): update dependency @arkecosystem/platform-sdk to ^0.9.0 (#606)
7ad21a3 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@luciorubeens
fix: profile signin page height (#610)
107c671
@luciorubeens @clucasalcantara
fix: settings page header on android (#611)
20917cf 
* fix: settings page header on android

* chore: remove old page

Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@renovate @renovate-bot @clucasalcantara
fix(deps): update dependency @arkecosystem/platform-sdk-markets to ^0…
2ae73b2 
….9.0 (#607)

* fix(deps): update dependency @arkecosystem/platform-sdk-markets to ^0.9.0

* fix(deps): update dependency @arkecosystem/platform-sdk-markets to ^0.9.0

* refac: update wrong method name call

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caio Alcantara <alcantaracaiolucas@gmail.com>
@renovate @renovate-bot
fix(deps): update dependency cordova-plugin-x-socialsharing to v6 (#609)
b225df2 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@renovate @renovate-bot
chore(deps): update dependency karma-jasmine to ~3.2.0 (#618)
9779136 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@luciorubeens
fix: subscribe auth ctrl methods (#619)
f8f2779 
* fix: subscribe auth ctrl methods

* test: fix failing
@renovate @renovate-bot
fix(deps): update dependency cordova-plugin-ionic-webview to v5 (#621)
b6674a4 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@luciorubeens @clucasalcantara
fix: onboarding image size on iPhone (#622)
16105b7 
Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@clucasalcantara @luciorubeens
feat: add recipient list component (#613)
e1a460e 
Co-authored-by: Lúcio Rubens <4539235+luciorubeens@users.noreply.github.com>
@renovate @renovate-bot @clucasalcantara
chore(deps): update dependency karma-jasmine to ~3.3.0 (#625)
4fc459f 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caio Alcântara <alcantaracaiolucas@gmail.com>
@clucasalcantara
fix(build): add android x support (#629)
1d67911
@renovate
fix(deps): update dependency cordova-ios to v6 (#628)
6be1d26
@clucasalcantara
feat: redesign wallet passphrase check (#608)
938714d
@goga-m
refactor: replace bignumber with platform SDK (#630)
96e2098
@clucasalcantara
feat: wallet details redesign (#604)
2a02757
@clucasalcantara
feat: send coin screen (#626)
a4831ef
@luciorubeens
fix: chromedriver version to run e2e job (#644)
0042155
@renovate @renovate-bot
fix(deps): update dependency cordova-plugin-inappbrowser to v4 (#635)
ce5a021 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Sep 24, 2020
@dated dated changed the base branch from develop to master September 24, 2020 13:45
@dated dated closed this Sep 24, 2020
@ghost ghost mentioned this pull request Sep 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clucasalcantara clucasalcantara Awaiting requested review from clucasalcantara

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dated @luciorubeens @clucasalcantara @kalgoop @goga-m