Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove wallet data from URL #23

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 26, 2019

Remove the wallet data from the URL. Components will still be able to access this.$route.params.wallet but it won't be shown in the URL and reloading the page redirects to the homepage.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #23   +/-   ##
======================================
  Coverage    31.5%   31.5%           
======================================
  Files           5       5           
  Lines          73      73           
  Branches        3       3           
======================================
  Hits           23      23           
  Misses         50      50
Impacted Files Coverage Δ
src/router.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20883c9...78dd435. Read the comment docs.

@faustbrian faustbrian merged commit c8e1775 into master Jul 26, 2019
@ghost ghost deleted the faustbrian-patch-1 branch July 26, 2019 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants