Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return types #94

Merged
merged 4 commits into from
Sep 16, 2020
Merged

fix: return types #94

merged 4 commits into from
Sep 16, 2020

Conversation

repat
Copy link
Contributor

@repat repat commented Sep 16, 2020

Summary

See issue #93

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Sep 16, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #94   +/-   ##
=========================================
  Coverage     90.84%   90.84%           
- Complexity       66      114   +48     
=========================================
  Files            14       14           
  Lines           142      142           
=========================================
  Hits            129      129           
  Misses           13       13           
Impacted Files Coverage Δ Complexity Δ
src/API/AbstractAPI.php 0.00% <ø> (ø) 3.00 <0.00> (ø)
src/API/Blocks.php 100.00% <100.00%> (ø) 12.00 <12.00> (+6.00)
src/API/Bridgechains.php 100.00% <100.00%> (ø) 6.00 <6.00> (+3.00)
src/API/Businesses.php 100.00% <100.00%> (ø) 8.00 <8.00> (+4.00)
src/API/Delegates.php 100.00% <100.00%> (ø) 8.00 <8.00> (+4.00)
src/API/Locks.php 100.00% <100.00%> (ø) 8.00 <8.00> (+4.00)
src/API/Node.php 100.00% <100.00%> (ø) 10.00 <10.00> (+5.00)
src/API/Peers.php 100.00% <100.00%> (ø) 4.00 <4.00> (+2.00)
src/API/Rounds.php 100.00% <100.00%> (ø) 2.00 <2.00> (+1.00)
src/API/Transactions.php 100.00% <100.00%> (ø) 16.00 <16.00> (+8.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3755cb...95a886f. Read the comment docs.

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian changed the title Fix return types fix: return types Sep 16, 2020
@faustbrian faustbrian merged commit b3fe069 into ArkEcosystem:master Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. label Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Your pull request has been merged and marked as tier 3. It will earn you $50 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants