Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return types #94

Merged
merged 4 commits into from
Sep 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ composer.lock
phpunit.xml
vendor
clover.xml
.phpunit.result.cache
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
}],
"require": {
"php": "^7.2",
"guzzlehttp/guzzle": "^6.5",
"illuminate/support": "^6.0|^7.0"
"guzzlehttp/guzzle": "^6.5|^7.0",
"illuminate/support": "^6.0|^7.0|^8.0"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^2.16",
Expand Down
4 changes: 2 additions & 2 deletions src/API/AbstractAPI.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function __construct(Connection $connection)
* @param string $path
* @param array $query
*
* @return array|string
* @return array|null|bool
*/
protected function get(string $path, array $query = [])
{
Expand All @@ -63,7 +63,7 @@ protected function get(string $path, array $query = [])
* @param string $path
* @param array $parameters
*
* @return array|string
* @return array|null|bool
*/
protected function post(string $path, array $parameters = [])
{
Expand Down
12 changes: 6 additions & 6 deletions src/API/Blocks.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Blocks extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('blocks', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("blocks/{$id}");
}
Expand All @@ -49,7 +49,7 @@ public function show(string $id): array
*
* @return array
*/
public function first(): array
public function first(): ?array
{
return $this->get('blocks/first');
}
Expand All @@ -59,7 +59,7 @@ public function first(): array
*
* @return array
*/
public function last(): array
public function last(): ?array
{
return $this->get('blocks/last');
}
Expand All @@ -72,7 +72,7 @@ public function last(): array
*
* @return array
*/
public function transactions(string $id, array $query = []): array
public function transactions(string $id, array $query = []): ?array
{
return $this->get("blocks/{$id}/transactions", $query);
}
Expand All @@ -84,7 +84,7 @@ public function transactions(string $id, array $query = []): array
*
* @return array
*/
public function search(array $parameters): array
public function search(array $parameters): ?array
{
return $this->post('blocks/search', $parameters);
}
Expand Down
6 changes: 3 additions & 3 deletions src/API/Bridgechains.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Bridgechains extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('bridgechains', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("bridgechain/{$id}");
}
Expand All @@ -51,7 +51,7 @@ public function show(string $id): array
*
* @return array
*/
public function search(array $parameters): array
public function search(array $parameters): ?array
{
return $this->post('bridgechain/search', $parameters);
}
Expand Down
8 changes: 4 additions & 4 deletions src/API/Businesses.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Businesses extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('businesses', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("businesses/{$id}");
}
Expand All @@ -52,7 +52,7 @@ public function show(string $id): array
*
* @return array
*/
public function bridgechains(string $id, array $query = []): array
public function bridgechains(string $id, array $query = []): ?array
{
return $this->get("businesses/{$id}/bridgechains", $query);
}
Expand All @@ -64,7 +64,7 @@ public function bridgechains(string $id, array $query = []): array
*
* @return array
*/
public function search(array $parameters): array
public function search(array $parameters): ?array
{
return $this->post('businesses/search', $parameters);
}
Expand Down
8 changes: 4 additions & 4 deletions src/API/Delegates.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Delegates extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('delegates', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("delegates/{$id}");
}
Expand All @@ -52,7 +52,7 @@ public function show(string $id): array
*
* @return array
*/
public function blocks(string $id, array $query = []): array
public function blocks(string $id, array $query = []): ?array
{
return $this->get("delegates/{$id}/blocks", $query);
}
Expand All @@ -65,7 +65,7 @@ public function blocks(string $id, array $query = []): array
*
* @return array
*/
public function voters(string $id, array $query = []): array
public function voters(string $id, array $query = []): ?array
{
return $this->get("delegates/{$id}/voters", $query);
}
Expand Down
8 changes: 4 additions & 4 deletions src/API/Locks.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Locks extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('locks', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("locks/{$id}");
}
Expand All @@ -51,7 +51,7 @@ public function show(string $id): array
*
* @return array
*/
public function search(array $parameters): array
public function search(array $parameters): ?array
{
return $this->post('locks/search', $parameters);
}
Expand All @@ -63,7 +63,7 @@ public function search(array $parameters): array
*
* @return array
*/
public function unlocked(array $parameters): array
public function unlocked(array $parameters): ?array
{
return $this->post('locks/unlocked', $parameters);
}
Expand Down
10 changes: 5 additions & 5 deletions src/API/Node.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Node extends AbstractAPI
*
* @return array
*/
public function status(): array
public function status(): ?array
{
return $this->get('node/status');
}
Expand All @@ -35,7 +35,7 @@ public function status(): array
*
* @return array
*/
public function syncing(): array
public function syncing(): ?array
{
return $this->get('node/syncing');
}
Expand All @@ -45,7 +45,7 @@ public function syncing(): array
*
* @return array
*/
public function configuration(): array
public function configuration(): ?array
{
return $this->get('node/configuration');
}
Expand All @@ -55,7 +55,7 @@ public function configuration(): array
*
* @return array
*/
public function crypto(): array
public function crypto(): ?array
{
return $this->get('node/configuration/crypto');
}
Expand All @@ -67,7 +67,7 @@ public function crypto(): array
*
* @return array
*/
public function fees(int $days = null): array
public function fees(int $days = null): ?array
{
return $this->get('node/fees', ['days' => $days]);
}
Expand Down
4 changes: 2 additions & 2 deletions src/API/Peers.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Peers extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('peers', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $ip): array
public function show(string $ip): ?array
{
return $this->get("peers/{$ip}");
}
Expand Down
2 changes: 1 addition & 1 deletion src/API/Rounds.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Rounds extends AbstractAPI
*
* @return array
*/
public function delegates(int $round_id): array
public function delegates(int $round_id): ?array
{
return $this->get("rounds/{$round_id}/delegates");
}
Expand Down
16 changes: 8 additions & 8 deletions src/API/Transactions.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Transactions extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('transactions', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function create(array $transactions): array
public function create(array $transactions): ?array
{
return $this->post('transactions', compact('transactions'));
}
Expand All @@ -51,7 +51,7 @@ public function create(array $transactions): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("transactions/{$id}");
}
Expand All @@ -61,7 +61,7 @@ public function show(string $id): array
*
* @return array
*/
public function allUnconfirmed(): array
public function allUnconfirmed(): ?array
{
return $this->get('transactions/unconfirmed');
}
Expand All @@ -73,7 +73,7 @@ public function allUnconfirmed(): array
*
* @return array
*/
public function showUnconfirmed(string $id): array
public function showUnconfirmed(string $id): ?array
{
return $this->get("transactions/unconfirmed/{$id}");
}
Expand All @@ -85,7 +85,7 @@ public function showUnconfirmed(string $id): array
*
* @return array
*/
public function search(array $parameters): array
public function search(array $parameters): ?array
{
return $this->post('transactions/search', $parameters);
}
Expand All @@ -95,7 +95,7 @@ public function search(array $parameters): array
*
* @return array
*/
public function types(): array
public function types(): ?array
{
return $this->get('transactions/types');
}
Expand All @@ -105,7 +105,7 @@ public function types(): array
*
* @return array
*/
public function fees(): array
public function fees(): ?array
{
return $this->get('transactions/fees');
}
Expand Down
4 changes: 2 additions & 2 deletions src/API/Votes.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Votes extends AbstractAPI
*
* @return array
*/
public function all(array $query = []): array
public function all(array $query = []): ?array
{
return $this->get('votes', $query);
}
Expand All @@ -39,7 +39,7 @@ public function all(array $query = []): array
*
* @return array
*/
public function show(string $id): array
public function show(string $id): ?array
{
return $this->get("votes/{$id}");
}
Expand Down
Loading