Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable vendorfield for multipayment #81

Merged
merged 4 commits into from
Jan 3, 2020
Merged

fix: enable vendorfield for multipayment #81

merged 4 commits into from
Jan 3, 2020

Conversation

ItsANameToo
Copy link
Member

No description provided.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jan 3, 2020
@ItsANameToo
Copy link
Member Author

What's up with styleci :susp:

@codecov
Copy link

codecov bot commented Jan 3, 2020 •
edited
Loading

Codecov Report

Merging #81 into develop will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #81      +/-   ##
=============================================
+ Coverage      65.39%   65.64%   +0.25%     
- Complexity       218      220       +2     
=============================================
  Files             39       39              
  Lines            679      684       +5     
=============================================
+ Hits             444      449       +5     
  Misses           235      235
Impacted Files Coverage Δ Complexity Δ
src/Transactions/Builder/MultiPaymentBuilder.php 100% <100%> (ø) 6 <1> (+1) ⬆️
src/Transactions/Types/MultiPayment.php 100% <100%> (ø) 5 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687c525...ce74c56. Read the comment docs.

@faustbrian
Copy link
Contributor

faustbrian commented Jan 3, 2020 •
edited
Loading

Needs some tests for vendor field variants like https://github.com/ArkEcosystem/php-crypto/blob/develop/tests/Transactions/Builder/TransferTest.php

@ItsANameToo
Copy link
Member Author

👍

@faustbrian faustbrian changed the title fix: add vendorfield option to multipayment fix: enable vendorfield for multipayment Jan 3, 2020
@faustbrian faustbrian merged commit 81d9fe8 into develop Jan 3, 2020
@ghost ghost deleted the fix/multipayment-vendorfield branch January 3, 2020 10:20
@ghost ghost mentioned this pull request Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItsANameToo @faustbrian