Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Replace @hapi/joi with yup #399

Closed
faustbrian opened this issue Jun 8, 2020 · 0 comments · Fixed by #400
Closed

Replace @hapi/joi with yup #399

faustbrian opened this issue Jun 8, 2020 · 0 comments · Fixed by #400
Assignees
@faustbrian
Labels
Type: Refactor The pull request improves or enhances an existing implementation.

Comments

@faustbrian
Copy link
Contributor

The dependencies of the wallets use yup schemas under the hood so we should expose our schemas in the same format to support shared schemas and make the error behaviour deterministic.

https://github.com/jquense/yup
@faustbrian faustbrian added the Type: Refactor The pull request improves or enhances an existing implementation. label Jun 8, 2020
@faustbrian faustbrian added this to the 1.0.0 milestone Jun 8, 2020
@faustbrian faustbrian self-assigned this Jun 8, 2020
@faustbrian faustbrian changed the title Replaced @hapi/joi with yup Replace @hapi/joi with yup Jun 8, 2020
@faustbrian faustbrian mentioned this issue Jun 8, 2020
Merged
@ghost ghost mentioned this issue Jun 14, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@faustbrian faustbrian

Labels
Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace @hapi/joi with yup ArkEcosystemArchive/platform-sdk
1 participant
@faustbrian