Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

fix(profiles): ensure uniqueness of contact name #614

Merged
merged 2 commits into from
Aug 1, 2020
Merged

fix(profiles): ensure uniqueness of contact name #614

merged 2 commits into from
Aug 1, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 1, 2020

Summary

Adds checks to ensure the uniqueness of a contacts name during creation and update.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner August 1, 2020 16:04
@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #614 into master will increase coverage by 0.24%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   64.12%   64.37%   +0.24%     
==========================================
  Files          82       83       +1     
  Lines        1550     1569      +19     
  Branches      138      144       +6     
==========================================
+ Hits          994     1010      +16     
- Misses        523      524       +1     
- Partials       33       35       +2     
Flag Coverage Δ
#unit 64.37% <93.75%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dk-profiles/src/repositories/contact-repository.ts 92.72% <93.33%> (+3.36%) ⬆️
packages/platform-sdk-profiles/src/profile.ts 69.49% <100.00%> (ø)
packages/platform-sdk-coincap/src/utils.ts 63.63% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cce3b5...629528b. Read the comment docs.

@faustbrian faustbrian changed the title feat(profiles): ensure uniqueness of contact name fix(profiles): ensure uniqueness of contact name Aug 1, 2020
@faustbrian faustbrian merged commit ac50eac into ArkEcosystemArchive:master Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants