Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crypto endpoint #54

Merged
merged 6 commits into from Sep 2, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Sep 2, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   74.35%   74.57%   +0.21%     
==========================================
  Files          12       12              
  Lines         117      118       +1     
  Branches       10       10              
==========================================
+ Hits           87       88       +1     
  Misses         30       30
Impacted Files Coverage Δ
src/resources/node.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfdd8e...b04d695. Read the comment docs.

@faustbrian faustbrian merged commit fa93a6f into master Sep 2, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: node-10 Your tests passed on CircleCI!
Details
ci/circleci: node-11 Your tests passed on CircleCI!
Details
ci/circleci: node-12 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the feat/crypto-endpoint branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.