Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: resource methods #99

Merged
merged 17 commits into from
Feb 25, 2020
Merged

types: resource methods #99

merged 17 commits into from
Feb 25, 2020

Conversation

rigwild
Copy link
Contributor

@rigwild rigwild commented Feb 24, 2020

Summary

What changes are being made?

  • Added http query support when POST request is used
  • Added first and last blocks resources methods
  • Added schemas transactions resources method
  • Added search delegates resources method
  • Added debug node resources method
  • Fully documented methods
  • Fully typed methods parameters

Why are these changes necessary?

  • Better editor intellisense
  • Add missing methods that are mentionned in the API documentation

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Quick regex to convert any documentation tables to a TypeScript interface :
Search: ^\| (.*?) \| (.*?) \| (.*?) \|.*
Replace: \/\*\* \3 \*\/\n\1\: \2;

Note: I deleted my fork used for PR #96 after the another PR of the same fork was merged. The PR is now orphan. My bad!

@ghost
Copy link

ghost commented Feb 24, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Undetermined Needs specialized, in-depth review. label Feb 24, 2020
@rigwild rigwild mentioned this pull request Feb 24, 2020
3 tasks
@faustbrian faustbrian added the Bounty: Tier 1 Awarded for very large features, refactorings, improvements. This is valued at 200 USD. label Feb 25, 2020
@ghost
Copy link

ghost commented Feb 25, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 25, 2020
@faustbrian faustbrian merged commit 721ff20 into ArkEcosystem:master Feb 25, 2020
@ghost
Copy link

ghost commented Feb 25, 2020

Your pull request has been merged and marked as tier 1. It will earn you $200 USD.

@rigwild rigwild deleted the resources-methods-typings-doc branch February 25, 2020 09:40
@boldninja
Copy link
Member

@rigwild Can you provide me with your ARK address so I can send you your bounty reward? You can also contact me on ARK's Slack - https://ark.io/slack (username : Rok [ARK Team]) and direct message me your address there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 1 Awarded for very large features, refactorings, improvements. This is valued at 200 USD. Complexity: Undetermined Needs specialized, in-depth review. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants