Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: resource methods - orphan fork #96

Closed
wants to merge 16 commits into from
Closed

types: resource methods - orphan fork #96

wants to merge 16 commits into from

Conversation

rigwild
Copy link
Contributor

@rigwild rigwild commented Feb 23, 2020

Summary

What changes are being made?

  • Added http query support when POST request is used
  • Added first and last blocks resources methods
  • Added schemas transactions resources method
  • Added search delegates resources method
  • Added debug node resources method
  • Fully documented methods
  • Fully typed methods parameters

Why are these changes necessary?

  • Better editor intellisense
  • Add missing methods that are mentionned in the API documentation

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Quick regex to convert any documentation tables to a TypeScript interface :
Search: ^\| (.*?) \| (.*?) \| (.*?) \|.*
Replace: \/\*\* \3 \*\/\n\1\: \2;

@ghost
Copy link

ghost commented Feb 23, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: High More than 256 lines changed. label Feb 23, 2020
@faustbrian faustbrian changed the title Resources methods typings and doc types: resource methods Feb 24, 2020
@faustbrian
Copy link
Contributor

@rigwild conflicts

@rigwild rigwild changed the title types: resource methods types: resource methods - orphan fork Feb 24, 2020
@rigwild rigwild closed this Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

@rigwild rigwild mentioned this pull request Feb 24, 2020
3 tasks
@rigwild
Copy link
Contributor Author

rigwild commented Feb 24, 2020

Orphan PR. See #99 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants