Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import benchmark functions directly to fix odd performance issues #22

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

faustbrian
Copy link
Contributor

Summary

This PR changes the imports from the full dist folder to only the tested function. I was observing an odd behaviour where functions would be 10x to 30x slower then lodash if they were imported from the dist directory and used as utils.function instead of directly imported.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Sep 23, 2019
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         108    108           
  Lines         543    541    -2     
  Branches       38     38           
=====================================
- Hits          543    541    -2
Impacted Files Coverage Δ
src/max-by.ts 100% <100%> (ø) ⬆️
src/min-by.ts 100% <100%> (ø) ⬆️
src/is-equal.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c210e04...ccdfd4d. Read the comment docs.

@faustbrian faustbrian merged commit 66e7b70 into master Sep 23, 2019
@ghost ghost deleted the weird branch September 23, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant