Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "two" references #54

Merged
merged 3 commits into from
Jan 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/cpp.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ please see the [Cpp Crypto](https://github.com/ArkEcosystem/cpp-crypto) reposito
### Connection

Before making a request, you should create a `Connection`.
A `Connection` expects a `host`, which is an url on which the API can be reached,
and a network `version`, which specifies whether we are using v1 or v2.
An example `Connection` that connects to a v2 API of a node, would be created as follows:
A `Connection` expects a `host`, which is an url on which the API can be reached.
An example `Connection`, that interfaces with the API of an Ark Node, would be created as follows:

```cpp
// Create a connection
Expand Down
2 changes: 1 addition & 1 deletion examples/platformio_example/src/main.ino
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ void setup() {

void loop() {
// Create a connection
Ark::Client::Connection<Ark::Client::API::Two> connection("167.114.29.54", 4003);
Ark::Client::Connection<Ark::Client::Api> connection("167.114.29.54", 4003);

// Check the API Version
const auto apiVersion = connection.api.version();
Expand Down
2 changes: 1 addition & 1 deletion test/api/blocks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using testing::Return;
using testing::_;

/* test_two_blocks_block
/* test_blocks_block
* https://dexplorer.ark.io:8443/api/v2/blocks/13114381566690093367
* Expected Response:
{
Expand Down
2 changes: 1 addition & 1 deletion test/api/delegates.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using testing::Return;
using testing::_;

/* test_two_delegates_delegate
/* test_delegates_delegate
* https://dexplorer.ark.io:8443/api/v2/delegates/boldninja
* Expected Response:
{
Expand Down
8 changes: 4 additions & 4 deletions test/api/node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

using testing::Return;

/* test_two_node_configuration
/* test_node_configuration
* https://dexplorer.ark.io:8443/api/v2/node/configuration
* Expected Response:
{
Expand Down Expand Up @@ -103,7 +103,7 @@ using testing::Return;
}
}
*/
TEST(api, test_two_node_configuration) { // NOLINT
TEST(api, test_node_configuration) { // NOLINT
Ark::Client::Connection<MockApi> connection("167.114.29.54", 4003);

auto apiVersion = connection.api.version();
Expand Down Expand Up @@ -201,7 +201,7 @@ TEST(api, test_two_node_configuration) { // NOLINT
}
}
*/
TEST(api, test_two_node_status) { // NOLINT
TEST(api, test_node_status) { // NOLINT
Ark::Client::Connection<MockApi> connection("167.114.29.54", 4003);

auto apiVersion = connection.api.version();
Expand Down Expand Up @@ -248,7 +248,7 @@ TEST(api, test_two_node_status) { // NOLINT
}
}
*/
TEST(api, test_two_node_syncing) { // NOLINT
TEST(api, test_node_syncing) { // NOLINT
Ark::Client::Connection<MockApi> connection("167.114.29.54", 4003);

auto apiVersion = connection.api.version();
Expand Down
6 changes: 3 additions & 3 deletions test/api/peers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
using testing::Return;
using testing::_;

/* test_two_peers_peer
/* test_peers_peer
* https://dexplorer.ark.io:8443/api/v2/peers/167.114.29.54
* Expected Response:
{
Expand All @@ -24,7 +24,7 @@ using testing::_;
}
}
*/
TEST(api, test_two_peer) { // NOLINT
TEST(api, test_peer) { // NOLINT
Ark::Client::Connection<MockApi> connection("167.114.29.54", 4003);

auto apiVersion = connection.api.version();
Expand Down Expand Up @@ -97,7 +97,7 @@ TEST(api, test_two_peer) { // NOLINT
]
}
*/
TEST(api, test_two_peers) { // NOLINT
TEST(api, test_peers) { // NOLINT
Ark::Client::Connection<MockApi> connection("167.114.29.55", 4003);

auto apiVersion = connection.api.version();
Expand Down
2 changes: 1 addition & 1 deletion test/api/transactions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
using testing::Return;
using testing::_;

/* test_two_transactions_transaction
/* test_transactions_transaction
* https://dexplorer.ark.io:8443/api/v2/transactions/b324cea5c5a6c15e6ced3ec9c3135a8022eeadb8169f7ba66c80ebc82b0ac850
* Expected Response:
{
Expand Down
2 changes: 1 addition & 1 deletion test/api/votes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
using testing::Return;
using testing::_;

/* test_two_vote
/* test_vote
* https://dexplorer.ark.io:8443/api/v2/votes/d202acbfa947acac53ada2ac8a0eb662c9f75421ede3b10a42759352968b4ed2
* Expected Response:
{
Expand Down
2 changes: 1 addition & 1 deletion test/api/wallets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
using testing::Return;
using testing::_;

/* test_two_vote_identifier
/* test_vote_identifier
* https://dexplorer.ark.io:8443/api/v2/wallets/DKrACQw7ytoU2gjppy3qKeE2dQhZjfXYqu
* Expected Response:
{
Expand Down