Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rahilansari261 active nav link #149

Merged
merged 5 commits into from
May 29, 2023

Conversation

rahilansari261
Copy link
Contributor

What does this PR do?

feat
added some classes to nav bar link to highlight them

Screenshot from 2023-05-29 12-42-25

Screenshot from 2023-05-29 12-42-20

Screenshot from 2023-05-29 12-42-12

Screenshot from 2023-05-29 12-41-58

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-hive ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 9:48am

@rahilansari261
Copy link
Contributor Author

@ArslanYM
merging this PR will fix below bugs.

divs get the height and width
fix: added some paadiny to hero and images
fix: hero text gets some padding and align self
feat: nav link active class added

Copy link
Owner

@ArslanYM ArslanYM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ArslanYM ArslanYM merged commit 0a06865 into ArslanYM:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants