Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merklev2 Type to Merklev3 #399

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Merklev2 Type to Merklev3 #399

merged 3 commits into from
Nov 30, 2022

Conversation

mchrupcala
Copy link
Contributor

No description provided.

ryley-o
ryley-o approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@ryley-o ryley-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm going to tag you in a follow-on PR, as this exposed a slight hole in our tests (although, this would have never made it to mainnet as we immediately saw)

@mchrupcala mchrupcala marked this pull request as ready for review November 30, 2022 21:10
@mchrupcala mchrupcala requested a review from a team as a code owner November 30, 2022 21:10
@mchrupcala mchrupcala merged commit 0d71e74 into main Nov 30, 2022
@mchrupcala mchrupcala deleted the merklev3-type branch November 30, 2022 21:10
@ryley-o ryley-o mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryley-o ryley-o ryley-o approved these changes

@jakerockland jakerockland Awaiting requested review from jakerockland jakerockland is a code owner automatically assigned from ArtBlocks/eng-approvers-contracts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchrupcala @ryley-o