Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nix package run option #73

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add Nix package run option #73

merged 1 commit into from
Mar 25, 2024

Conversation

petertrotman
Copy link
Contributor

Currently available at my nixpkgs fork, but hopefully it will be merged upstream soon.

@petertrotman
Add Nix package run option
ed348a2 
Currently available at my nixpkgs fork, but hopefully it can be merged upstream soon (tm).
@petertrotman
Copy link
Contributor Author

I should mention that I removed the uuid dependency in the build since it didn't seem to be needed - if there is some effect this has that I'm not aware of then let me know I can add it back in.

@ArthurSonzogni
Copy link
Owner

Currently available at my nixpkgs fork, but hopefully it will be merged upstream soon.

Excellent! Thanks for working on this!

I don't know nix much. I know we now have a flake.nix in FTXUI. Please let me know if there is a need to maintain something directly in this repository.

I should mention that I removed the uuid dependency in the build since it didn't seem to be needed - if there is some effect this has that I'm not aware of then let me know I can add it back in.

I think you are right!
It was added as part of: #26
This was a dependency in ANTLR, but it looks like it has been removed recently: antlr/antlr4@0b8ed20

ArthurSonzogni
ArthurSonzogni approved these changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@ArthurSonzogni ArthurSonzogni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArthurSonzogni ArthurSonzogni merged commit 88e365d into ArthurSonzogni:main Mar 25, 2024
4 of 5 checks passed
ArthurSonzogni added a commit that referenced this pull request Mar 25, 2024
@ArthurSonzogni
Remove libuuid dependency.
1e80fb5 
It was added as part of:
#26

This was a dependency in ANTLR, but it looks like it has been removed recently:
antlr/antlr4@0b8ed20

This was found by @petertrotman in
#73
@petertrotman
Copy link
Contributor Author

Excellent! Thanks for working on this!

No problem, thank you for the program :-)

Please let me know if there is a need to maintain something directly in this repository.

No, a flake in-repo is one way of defining a package but all I have done is translate the build instructions into nix. Basically it just automates cloning the dependencies and running make in a way that is reproducible for other nix users. If a future release requires a fix from my build script then I have volunteered to take that on myself.

All the best,

P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSonzogni ArthurSonzogni ArthurSonzogni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrotman @ArthurSonzogni