-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor each component into it's own separate folder #83
Comments
Can you assign this to me? |
Sure go ahead! @smabbett |
I'm having trouble running the project. Yarn installed, and I ran 'yarn start'. I'm getting some warnings. Is there anything else I need to install? |
There was some heavy refactoring in the past couple of days which aren't yet fully completed as this is an active development branch as you can tell. Sorry for the hassle. Can you share screenshots of the warnings @smabbett ? If something's quite serious at the moment, you can use the library this way (I'll update this somewhere for future reference) :
Refer to this simple article if I wasn't clear enough: https://simplernerd.com/test-npm-package-locally/ Hope this helps. Sorry for all the trouble. Do let me know if you face any difficulties. |
Okay I'll take a look at them. Read my previous comment to see how to actually use it, and for this issue, given we didn't see this earlier, you can still work for now without running it as it involves just some easy refactors, till we fix this. Works? @smabbett |
I did a pull request |
Yeah @smabbett it's merged. But I see you didn't fix the imports so could you send another PR fixing the imports in the index.js and index.ts files? I mentioned it as the last line in the description of this issue. Take a look. |
Sorry, I'm pretty new to this. I don't see index.js or index.ts files. |
@smabbett It's in the components folder itself... along with all the folders you created |
Refactor each component into it's own separate folder. for eg.
IMPORTANT: Branch to contribute to: convert_to_npm
Current:
Desired:
IMPORTANT: Also accordingly fix its import in index.js and index.ts for each component appropriately.
The text was updated successfully, but these errors were encountered: