Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs_to_bottom.userchrome.css for firefox version 119 #5

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

lilly-lizard
Copy link
Contributor

Firefox version 119 removed the navigator-toolbox-background class meaning that the navigator toolbox was not being moved to the bottom of the window anymore. Renaming it to navigator-toolbox fixes this.

@lilly-lizard
Copy link
Contributor Author

lilly-lizard commented Oct 29, 2023

Note that this will obviously no longer work for 118.0.2 and prior but I just tried having both at the same time...

/* for version 119 up */
#navigator-toolbox {
        -moz-box-ordinal-group: 1 !important;
        order: 1 !important;
}

/* for version 118.0.2 and prior */
#navigator-toolbox-background {
        -moz-box-ordinal-group: 1 !important;
        order: 1 !important;
}

and it works on both 118.0.2 and 119. Up to you wherever backwards compatibility is worth making the code a bit more messy

@FirefoxSurvivor
Copy link

Hello there,

I asked for help about this issue two weeks ago here: https://gist.github.com/Arty2/e6e61801531ec5ee1f9f

I restored v11.8.0.2 but removing "-background" from the userChrome.css file, like You wrote, didn't work for me. I also tried removing the other "-background" that is upper, but nothing. Any idea?

Thank You anyway. I hope this problem will be fixed soon.

@FirefoxSurvivor
Copy link

Sorry, maybe i didn't explain well what i mean: on Firefox 118.0.2 the addon works fine as it is. But if i remove "-background" tabs and url bar come back to top. However, i didn't try Your suggestion yet on Firefox 119.

@FirefoxSurvivor
Copy link

It's again me. I updated to 119 and Your fix works just fine. Thank You! I can't image how the hell You understood the cause, but You are great. Bye!

@lilly-lizard
Copy link
Contributor Author

@FirefoxSurvivor nice username haha. glad it worked! fyi you can use the browser toolbox to figure out the css names of the firefox ui elements which is how I figured out that navigator-toolbox-background needed to be renamed to navigator-toolbox for version 119

Copy link
Owner

@Arty2 Arty2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and for your time looking into this. The hours that have gone into maintaining such a short piece of code thought the years is unimaginable.

@Arty2 Arty2 merged commit b606c28 into Arty2:master Nov 6, 2023
@lilly-lizard lilly-lizard deleted the tabs-to-bottom-119-fix branch November 7, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants