-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Pull Request Template with Checklist for Code Checks and Issue Linking #21
Comments
/assign |
@ArvindParekh seems good for you that template? |
Thanks for raising @abeltavares! I think this looks good!
What do you think? |
seems good, the update (with tests check) is done later then with the integration of the tests
|
Perfect, looks great! 👍🏻 |
Want to standardize pull requests and ensure that they meet the project's contribution guidelines, so I propose implementing a pull request template.
The proposed PR template will include the following items:
Link to Issue: Ensure contributors explicitly link PRs to corresponding issues using the closes #issue_number syntax, making it easier to track and automate closure of issues when PRs are merged.
Code Checks: Include a checkbox to confirm that all code checks have passed. This is relevant as we plan to implement pre-commit hooks using Prettier for style checks, ensuring that all submitted code is accordingly to our formatting standards.
Testing: Confirm that new code contributions have adequate tests and that all tests pass.
Implementation:
Create the PR Template: Add a
PULL_REQUEST_TEMPLATE.md
file in the .github directory with the proposed checklist.We can open a discussion bellow in the comments to finalize the checklist items with input from maintainers and active contributors.
My ideia:
The text was updated successfully, but these errors were encountered: