-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize the frontend app & the backend services #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @hazemessam 👏
NOTE : Before start working on requested changes, I would highly recommend you to run this project locally and try to upload & search query on sample-log file
present in root directory of the project.
Some changes I would suggest before merging this one:
- I tested your PR and found that docker-compose missing
elasticsearch service
and it is essential for this project to run properly.
Some references that might help you 👇
- https://tamerlan.dev/how-to-integrate-elasticsearch-with-drf/
- https://dev.to/aymanemx/building-a-full-text-search-app-using-django-docker-and-elasticsearch-3bai
- https://github.com/barseghyanartur/django-elasticsearch-dsl-drf/blob/master/docker-compose.yml
-
Please update
CORS_ORIGIN_WHITELIST & ALLOWED HOSTS
as well because it's giving me 500 Internal server errors on console.
Lines 79 to 82 in c2a72f5
CORS_ORIGIN_WHITELIST = [ "http://127.0.0.1:3000", "http://localhost:3000", ]
Line 28 in c2a72f5
ALLOWED_HOSTS = [] -
Frontend also not working properly in docker, It's unable to download frontend dependencies through
npm install
and also make sure you changebackend url
👇
const url = `http://localhost:8000/api/document/`; -
It would be better if you could attach any kind of
GIF/Video
in your PR to showcase your work 🙂
Please, note that we don't need to change the backend address from |
You're right 👍, It just mapped localhost address. We don't need to change that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hazemessam Great work, Thanks 👍👍
Related Issues or bug
Fixes: #22