Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the 12.4 IPSW #249

Closed
wants to merge 1 commit into from
Closed

remove the 12.4 IPSW #249

wants to merge 1 commit into from

Conversation

zzywysm
Copy link
Contributor

@zzywysm zzywysm commented Jan 4, 2024

In a previous commit from December 23, 2023, Hector removed the ability to install 12.4 even in expert mode.

This suggests that the 12.4 IPSW is no longer necessary. Remove it.

In a previous commit from December 23, 2023, Hector removed the ability to install 12.4 even in expert mode.

This suggests that the 12.4 IPSW is no longer necessary. Remove it.

Signed-off-by: Zzy Wysm <zzy@zzywysm.com>
@zzywysm
Copy link
Contributor Author

zzywysm commented Jan 4, 2024

Not sure why the DCO check failed, my commit appears to have the appropriate sign-off...

@eiln
Copy link

eiln commented Feb 19, 2024

https://github.com/AsahiLinux/asahi-installer/pull/249/checks?check_run_id=20148724962

Commit sha: 7fa8527, Author: Zzy Wysm, Committer: GitHub; Expected "Zzy Wysm 51676322+zzywysm@users.noreply.github.com", but got "Zzy Wysm zzy@zzywysm.com".

Maybe the email isn't added to your github account? The DCO check is not a dealbreaker (we just want record of authorship, see https://asahilinux.org/copyright) but adding the email would be helpful for future submissions.

@zzywysm zzywysm closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants