Added support for Faraday 2 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igor-alexandrov Thank you for sending this PR. Do you also mind updating the Appraisals file. I think the GitHub action builds are failing because of it. |
|
@jv-asana added two latest |
jv-asana
approved these changes
Mar 3, 2023
|
@jv-asana will you also release gem to Rubygems? |
Hi @igor-alexandrov I was going to wait until we update our library with new endpoints but I can go ahead and release it now instead of waiting. |
|
@jv-asana no reason to rush, release it when you consider the right time to do this. |
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Faraday 2 to
asanagem (#141).All specs pass, I've also tested this in my project and everything works well.
Let's discuss.