Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row too big to fit into CursorWindow #312

Closed
Evilhotdog opened this issue Jan 12, 2023 · 16 comments
Closed

Row too big to fit into CursorWindow #312

Evilhotdog opened this issue Jan 12, 2023 · 16 comments
Labels
bug Something isn't working

Comments

@Evilhotdog
Copy link

1. Environment

  • Device: Fairphone 4
  • OS: CalyxOS 4.5.0
  • APP: 0.9.6

2. Describe the bug
When attempting to read Planet KDE (or any group containing Planet KDE articles (perhaps a single offending article), no articles are visible, with the following error:
Row too big to fit into CursorWindow
requiredPos = 14, totalRows = 15

@Evilhotdog Evilhotdog added the bug Something isn't working label Jan 12, 2023
@algatern
Copy link

I am getting the same error.

I added a new subscription. When I tap on that subscription to view articles, I see a blank page and get this message:
Row too big to fit into CursorWindow requiredPos=47, totalRows=48

Read You version 0.9.8
Device: Onyx Boox Tab Ultra C
OS: Boox OS, based on Android 11

@zabir128
Copy link

zabir128 commented Oct 7, 2023

Im getting the same error today in v 0.9.8. It was working nice untill today. Just one rss link, others are ok. Giving this error while entering the that link:
"Row too big to fit into CursorWindow
requiredPos = 104, totalRows = 105"

It is not device specific. It is giving the same error in another device.

@zabir128
Copy link

zabir128 commented Oct 8, 2023

I cleared the contents of the link, now refreshed todays rss contents with no proplem.

so the temporary solution: clear the feeds/contents/aticles of that link.

@kermes
Copy link

kermes commented Jan 10, 2024

Getting the same in one of my feeds. Clearing content and refreshing doesn't work.
It's probably a single article that's causing this so once it's not present in the live feed anymore I guess clearing and refreshing will work again.... until they add an article that exceeds whatever limit there's in sqlite

Row too big to fit into CursorWindow
requiredPos = 44, totalRows = 45
  • Device: Google Pixel 6a
  • OS: Android 14
  • APP: 0.9.8

@mbestavros
Copy link
Collaborator

mbestavros commented Jan 10, 2024

This one might be tricky to track down, from a quick look into the codebase. It seems like the toast message comes from an uncaught exception, but from where isn't immediately obvious.

If one of the people on the thread is able to provide logs (@kermes?) when they encounter the bug, that would be extremely helpful, I'm sure.

@mbestavros
Copy link
Collaborator

Ah, looks like it's a bigger issue than Read You: andpor/react-native-sqlite-storage#364

@Ashinch We could try implementing this fix? andpor/react-native-sqlite-storage#364 (comment)

@kermes
Copy link

kermes commented Jan 10, 2024

Nice catch @mbestavros

I don't have access to android studio right now to check the logs, but if it helps, this is the feed failing for me right now:
https://www.newtral.es/feed/

@mbestavros
Copy link
Collaborator

Aha! Found it! This is the database function that's causing the bug: https://github.com/Ashinch/ReadYou/blob/main/app/src/main/java/me/ash/reader/domain/repository/ArticleDao.kt#L482

Thank you @kermes, that was extremely helpful!

@mbestavros
Copy link
Collaborator

@Ashinch Do you think it's worth trying the above fix I linked to?

If you'd like to, let's try and get that in before our next bugfix release. If not, I'll just cut a release with the SVG fix.

@Ashinch
Copy link
Owner

Ashinch commented Jan 12, 2024

@Ashinch Do you think it's worth trying the above fix I linked to?

If you'd like to, let's try and get that in before our next bugfix release. If not, I'll just cut a release with the SVG fix.

@mbestavros

This issue is related to paging and seems challenging. In the next version, we can include SVG and other fix patches.

@mbestavros
Copy link
Collaborator

mbestavros commented Jan 12, 2024

@Ashinch Sounds good. Are there any other bugfixes on the horizon? I'm inclined to push out one last update with the SVG and swipe fixes this week if there's nothing imminent. It should give users a relatively stable build while we wait for other fixes/features to cook.

@Ashinch
Copy link
Owner

Ashinch commented Jan 12, 2024

@Ashinch Sounds good. Are there any other bugfixes on the horizon? I'm inclined to push out one last update with the SVG and swipe fixes this week if there's nothing imminent. It should give users a relatively stable build while we wait for other fixes/features to cook.

@mbestavros

Yeah, it seems there are no urgent bugs that need fixing at the moment.

@mbestavros
Copy link
Collaborator

@Ashinch Awesome! I'm happy to draft a release tomorrow morning (it's late where I am) if you'd like, but also happy to defer to you.

@mbestavros
Copy link
Collaborator

PR #523 is a pretty effective workaround for this, but we may want to leave it open for further investigation. @Ashinch I'll leave the final decision up to you.

@Ashinch
Copy link
Owner

Ashinch commented Jan 12, 2024

PR #523 is a pretty effective workaround for this, but we may want to leave it open for further investigation. @Ashinch I'll leave the final decision up to you.

@mbestavros

Certainly, if you manage to reproduce the issue and confirm the fix works, I don't think it's necessary to worry.

@kermes
Copy link

kermes commented Jan 12, 2024 via email

@Ashinch Ashinch closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants