Insert current minecraft version into fabric version string #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #134, as the mod version string now adds the current minecraft version, since I assume that this project is switching to this format, judging by the newest tag name.
For this to work on the latest supported mc version (1.20.6), I bumped the version in gradle properties from 1.20.5 to 1.20.6. This generated no compiler warnings, and I also tested the newer version and found no errors, so, everything should work as expected.
I assume that this change requires a minor version bump, so the change will only work when a new release (1.6.9) is published, since I bumped the mod_version to 1.6.9. If it needs to be kept at 1.6.8 or changed in any other way, tell me and I'll change it (or change it yourself xd).