Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not include external libs #2

Closed
pcav opened this issue Feb 16, 2020 · 7 comments
Closed

Please do not include external libs #2

pcav opened this issue Feb 16, 2020 · 7 comments

Comments

@pcav
Copy link

pcav commented Feb 16, 2020

to avoid duplication of code, etc.
Since geographiclib is of rather general use, it would be probably appropriate to include it in the installers instead.

@Asratum
Copy link
Owner

Asratum commented Feb 16, 2020

the library in question is already included in a plugin in the official repository, so I assumed it would be okay to include it in mine:
https://github.com/NationalSecurityAgency/qgis-shapetools-plugin
I agree, it would be great to integrate the library in qgis (if that's what you mean), but my technical expertise is not good enough to do that at the moment on my own

@pcav
Copy link
Author

pcav commented Feb 16, 2020

Thanks for pointing out. Ticket opened on the other plugin.
Please open a ticket on OSGeo4W to ask including it.
In principle it is not difficult, you might be able to do it, or otherwise find a way of supporting it.
Thanks.

@Asratum
Copy link
Owner

Asratum commented Feb 16, 2020

OK, will open a ticket on OSGeo4W

@Asratum
Copy link
Owner

Asratum commented Feb 17, 2020

I see that the OSGeo4W ticket was closed (https://trac.osgeo.org/osgeo4w/ticket/621). When I see that it is present in the next version of QGIS, I will remove the external lib.

@pcav
Copy link
Author

pcav commented Feb 18, 2020 via email

@pcav
Copy link
Author

pcav commented Feb 18, 2020

Once included, please remove the lib so it can be published.

@Asratum
Copy link
Owner

Asratum commented Apr 8, 2022

External library removed with version 3.1.0, now using the QGIS one

@Asratum Asratum closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants