Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage item typo in unified accounts #1038

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

ashutoshvarma
Copy link
Member

@ashutoshvarma ashutoshvarma commented Oct 4, 2023

Pull Request Summary
Fix the typo in mapping storage names.

Since it's already deployed in Shibuya testnet, we have two options.

  1. Add migrations for this
  2. Clear the pallet storage using sudo call, since it's only being used internally and total mappings are around 10

EDIT: using OnRuntimeUpgrade hook to clear the storage in Shibuya for corrupted mappings after the renaming.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@ashutoshvarma ashutoshvarma added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Oct 4, 2023
runtime/shibuya/src/lib.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Code Coverage

Package Line Rate Branch Rate Health
pallets/dynamic-evm-base-fee/src 81% 0%
chain-extensions/types/assets/src 0% 0%
pallets/collator-selection/src 69% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/xcm/src 84% 0%
chain-extensions/dapps-staking/src 0% 0%
precompiles/sr25519/src 79% 0%
pallets/xvm/src 40% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/utils/src/testing 62% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/ethereum-checked/src 48% 0%
pallets/dapps-staking/src/pallet 85% 0%
chain-extensions/xvm/src 0% 0%
pallets/unified-accounts/src 80% 0%
precompiles/assets-erc20/src 76% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/batch/src 80% 0%
chain-extensions/types/dapps-staking/src 0% 0%
precompiles/utils/src 68% 0%
precompiles/xvm/src 75% 0%
primitives/src 62% 0%
pallets/pallet-xcm/src 53% 0%
pallets/dapps-staking/src 81% 0%
pallets/contracts-migration/src 0% 0%
precompiles/utils/macro/src 0% 0%
primitives/src/xcm 66% 0%
pallets/block-reward/src 85% 0%
Summary 58% (2652 / 4587) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go if all CI checks passed.

@ashutoshvarma ashutoshvarma merged commit 65172ec into master Oct 4, 2023
8 checks passed
@ashutoshvarma ashutoshvarma deleted the fix/au-typo branch October 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants